On 8/18/22 22:53, Gerald Pfeifer wrote:
> On Thu, 18 Aug 2022, Martin Liška wrote:
>> Ready for master?
> 
> Nearly. :)
> 
>> +    Link-time optimization improvements:
>> +    <ul>
>> +        <li>LTO supports the newly added GNU make's jobserver that uses 
>> named pipes (<code>--jobserver-style=fifo</code>)
> 
> I believe that's just "GNU make" (instead of "GNU make's"), or maybe 
> "...the newly added jobserver of GNU make...".
> 
> Not 100% sure myself.
> 
>> +        <li>If make's jobserver is active, parallel LTO WPA streaming 
>>    communicates with it and so the streaming
>> +        does not lead to the system overcommitting.</li>
> 
> Might we be able to simplify this to something like
> 
>   "...parallel LTO WPA streaming communicates with it and thus avoids
>   system overcommitting" ?
> 
> 
> Just two minor points; the patch as such looks fine.

Thanks for the review, installed with your suggestions.

Martin

> 
> Thank you,
> Gerald

Reply via email to