On Fri, Aug 05, 2022 at 09:35:33PM +0200, Ulrich Drepper via Gcc-patches wrote:
> How about adding a few more names from the std namespace to get appropriate
> hints?  This patch compiles and the appropriate messages are printed.  Is
> there a problem with just adding more or even at some point all the symbols
> of the standard library?

IMHO if the table in get_std_name_hint gets too big, we should probably see
if we can replace the O(n) search with something more efficient.
 
> gcc/ChangeLog:
> 
>         * cp/name-lookup.cc (get_std_name_hint): Add more symbols from the
>         <iomanip>, <ios>, <istream> and <ostream> headers.

Please drop the "cp/" prefix here.

Patch LGTM, but I can't approve.  Thanks and sorry for the delay,

Marek

Reply via email to