On Mon, Aug 15, 2022 at 06:14:22PM +0200, FX wrote:
> Thank you for taking this on (this patch and the Fortran ones), it is really
> appreciated and will improve gfortran's IEEE conformance.
>
> - "Implement __builtin_issignaling”: is approved for the tiny Fortran part
> - "libgfortran: Use __builtin_issignaling in libgfortran”: was approved by
> Thomas
Thanks.
> - I will have to look at the next two patches (ieee_value and ieee_class) in
> the next few days. I think we can make adjustments to the runtime library as
> well.
I think we can, but we need to make it in an ABI compatible way until
libgfortran bumps soname.
That is why I haven't used _gfortrani_whatever as name etc.
>
> Related: there are several tests in our testsuite that have {
> dg-require-effective-target issignaling }
> This is checked by check_effective_target_issignaling in
> gcc/testsuite/lib/target-supports.exp, and probes the support for the
> issignaling macro in <math.h>. I think it would make sense to adjust those
> tests to run on a wider range of targets, using the new built-in.
We could replace it with some other effective target that would test if the
target supports sNaNs (or perhaps just NaNs might be enough).
Jakub
