On Wed, Aug 10, 2022 at 02:39:02PM +0800, Xionghu Luo wrote: > On 2022/8/9 11:01, Kewen.Lin wrote: > >I have some concern on those changed "altivec_*_direct", IMHO the suffix > >"_direct" is normally to indicate the define_insn is mapped to the > >corresponding hw insn directly. With this change, for example, > >altivec_vmrghb_direct can be mapped into vmrghb or vmrglb, this looks > >misleading. Maybe we can add the corresponding _direct_le and _direct_be > >versions, both are mapped into the same insn but have different RTL > >patterns. Looking forward to Segher's and David's suggestions. > > Thanks! Do you mean same RTL patterns with different hw insn?
A pattern called altivec_vmrghb_direct_le should always emit a vmrghb instruction, never a vmrglb instead. Misleading names are an expensive problem. Segher
