Hi Segher, Thanks so much for your explanation. Now I have a clear picture about the usage of return value. Patch was committed as r13-1971.
Thanks Gui Haochen On 5/8/2022 上午 1:09, Segher Boessenkool wrote: > Hi! > > On Thu, Aug 04, 2022 at 05:55:20PM +0800, HAO CHEN GUI wrote: >> This patch corrects return value of check_p9modulo_hw_available. It should >> return 0 when p9modulo is supported. > > It would be harder to make such mistakes if it used exit() explicitly, > so that the reader is reminded the shell semantics are used here instead > of the C conventions. > >> - return (r == 2); >> + return (r != 2); > > so that then would be smth like > > if (r == 2) > exit (0); > else > exit (1); > > (which makes the exit code for failure explicit as well). > > Terse is good. Explicit is good as well :-) > > (You don't have to make this change here of course, but keep it in mind > for the future :-) ) > > > Segher
