> Hi Lewis,
>
> Thanks! Good spot. I think it should be calling dg-runtest however,
> same as what libphobos.cycles/cycles.exp is doing. Could also fix the
> test name so each one is unique, just to hit two birds in one -
> something like the following would suffice (haven't had time to check).
>
> Kind Regards,
> Iain.
>
> ---
>
> --- a/libphobos/testsuite/libphobos.unittest/unittest.exp
> +++ b/libphobos/testsuite/libphobos.unittest/unittest.exp
> @@ -42,8 +42,10 @@ foreach unit_test $unit_test_list {
> set expected_fail [lindex $unit_test 1]
>
> foreach test $tests {
> - set shouldfail $expected_fail
> - dg-test $test "" $test_flags
> + set libphobos_test_name "[dg-trim-dirname $srcdir $test] $test_flags"
> + set shouldfail $expected_fail
> + dg-runtest $test "" $test_flags
> + set libphobos_test_name ""
> }
>
> set shouldfail 0
>
Thanks for the followup. I tested and can confirm your version works fine:
PASS: libphobos.unittest/customhandler.d -fversion=FailNoPrintout (test for
excess errors)
PASS: libphobos.unittest/customhandler.d -fversion=FailNoPrintout execution test
PASS: libphobos.unittest/customhandler.d -fversion=FailedTests (test for excess
errors)
PASS: libphobos.unittest/customhandler.d -fversion=FailedTests execution test
PASS: libphobos.unittest/customhandler.d -fversion=GoodTests (test for excess
errors)
PASS: libphobos.unittest/customhandler.d -fversion=GoodTests execution test
PASS: libphobos.unittest/customhandler.d -fversion=NoTests (test for excess
errors)
PASS: libphobos.unittest/customhandler.d -fversion=NoTests execution test
PASS: libphobos.unittest/customhandler.d -fversion=PassNoPrintout (test for
excess errors)
PASS: libphobos.unittest/customhandler.d -fversion=PassNoPrintout execution test
Let me know if you want me to do anything from there please? By the way, there
are a few other tests that cause some minor glitches with comparing results:
libphobos.sum:PASS: libphobos.shared/link.d
-I/home/lewis/gccdev/base/src/libphobos/testsuite/libphobos.shared lib.so
-shared-libphobos (test for excess errors)
libphobos.sum:PASS: libphobos.shared/link.d
-I/home/lewis/gccdev/base/src/libphobos/testsuite/libphobos.shared lib.so
-shared-libphobos execution test
libphobos.sum:PASS: libphobos.shared/link_linkdep.d
-I/home/lewis/gccdev/base/src/libphobos/testsuite/libphobos.shared
liblinkdep.so lib.so -shared-libphobos (test for excess errors)
libphobos.sum:PASS: libphobos.shared/link_linkdep.d
-I/home/lewis/gccdev/base/src/libphobos/testsuite/libphobos.shared
liblinkdep.so lib.so -shared-libphobos execution test
libphobos.sum:PASS: libphobos.shared/link_loaddep.d
-I/home/lewis/gccdev/base/src/libphobos/testsuite/libphobos.shared
libloaddep.so -shared-libphobos (test for excess errors)
libphobos.sum:PASS: libphobos.shared/link_loaddep.d
-I/home/lewis/gccdev/base/src/libphobos/testsuite/libphobos.shared
libloaddep.so -shared-libphobos execution test
The problem here is that the absolute path to the test dir ends up in
the results summary, since it appears in the options string that is
part of the test name. It's not so hard to work around when doing the
comparisons, but it seems to be the only case where this happens in
the whole testsuite, other than one other similar case from libgo. Is
there a standard way to handle it I take it? Thanks...
-Lewis
