On Thu, 2022-07-07 at 21:56 -0400, Lewis Hyatt wrote: > Hello- > > The PR (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91733) points > out that, > while libcpp recognizes a lone '\r' as a valid line-ending character, > the > infrastructure that obtains source lines to be printed in diagnostics > does > not, and hence diagnostics do not output the intended portion of a > source > file that uses such line endings. The PR's author suggests that > libcpp > should stop accepting '\r' line endings, but that seems rather > controversial > and not likely to change. Fixing the diagnostics is easy enough > though, and > that's done by the attached patch. Please let me know if it looks OK, > thanks! bootstrap + regtest all languages looks good, with just new > PASSes > for the new testcase. > > FAIL 103 103 > PASS 543592 543627 > UNSUPPORTED 15298 15298 > UNTESTED 136 136 > XFAIL 4130 4130 > XPASS 20 20 >
The patch looks good to me. Thanks Dave
