On Fri, 24 Jun 2022 at 13:37, Xi Ruoyao <xry...@xry111.site> wrote: > > On Fri, 2022-06-24 at 13:41 +0200, Rainer Orth wrote: > > Hi Jonathan, > > > > > > > I'll need some rework as Rainer told me "grep -E" may not work on some > > > > > Solaris systems w/o GNU grep, and the code snippet in > > > > > extract_symvers.in > > > > > is exactly for Solaris... > > > > > > > > I checked that, and it's not :-) > > > > > > > > The egrep uses in extract_symvers.in are for everything *except* > > > > SunOS. For Solaris we use the scripts/extract_symvers.pl script > > > > instead. > > I misread the case statement :(. > > > > > Your change might break generation of Doxygen API docs on Solaris, but > > > > maybe we can live with that. > > > > > > /usr/xpg4/bin/grep supports the -E flag, so I was going to say that > > > it's acceptable to require that version in the PATH when generating > > > the API docs with doxygen. But in fact that script already assumes GNU > > > > indeed: for a niche/developer-only use, the bar of tool requirements can > > be higher IMO. Besides, /usr/gnu/bin/grep is there, too (or could be; > > both /usr/xpg4/bin/grep and /usr/gnu/bin/grep live in separate packages > > that may or may not be installed). > > > > I just want to make the entry barries for normal builds as low as > > possible. > > Pushed as r13-1242 with ChangeLog fix, as compatibility-related stuff > "resolved" and this does not depend on other patches in the series.
Great, thanks!
