Hi Kyrylo, On 2022/06/06 22:18 UTC+8, Kyrylo Tkachov wrote:
I'd rather not duplicate those structures and functions in the master branch, as they provide a maintenance burden to the community. If some tuning parameters need to be modified in the future for better performance we can create star-mc1-specific structures on demand then. Thus, I think we don't want this patch. Thanks, Kyrill
Thanks for the comment. Indeed, considering the maintenance burden to community, having those duplicate structures in the master branch is not a good idea. I am planning to contribute the star-mc1 pipeline machine description in the future. Maybe it would be better to propose new star-mc1 specific structure along with pipeline implementation then. Thanks for the review. I won't apply this 2/3 patch. Regards, jasonwucj
