Hi Andrew!
On 2022-05-24T16:27:52+0100, Andrew Stubbs <a...@codesourcery.com> wrote:
> I've committed this patch to set the minimum required LLVM version, for
> the assembler and linker, to 13.0.1. An upgrade from LLVM 9 is a
> prerequisite for the gfx90a support, and 13.0.1 is now the oldest
> version not known to have compatibility issues.
>
> The patch removes all the obsolete feature detection tests from
> configure and adds a new version test. Likewise the version dependencies
> in the backend are removed.
I've not otherwise reviewed your
commit r13-742-g8086230e7ac619c0b0eeb6e15df7975ac214725f
"amdgcn: Remove LLVM 9 assembler/linker support", but happened to notice
that your commit also removed the ARM-target 'HAVE_GAS_ARM_EXTENDED_ARCH'
-- is that intentional; I suppose not? That had been added by Richard
Earnshaw in commit r12-3725-g4e7a92c0ff3871d955ca8fb133f869b216d7224d
"arm: pass architecture extensions to assembler if supported".
> --- a/gcc/config.in
> +++ b/gcc/config.in
> -/* Define if your Arm assembler permits context-specific feature extensions.
> - */
> -#ifndef USED_FOR_TARGET
> -#undef HAVE_GAS_ARM_EXTENDED_ARCH
> -#endif
> -
> -
> --- a/gcc/configure
> +++ b/gcc/configure
> case "$target" in
> amdgcn-* | gcn-*)
> [...]
> ;;
> - arm*)
> - { $as_echo "$as_me:${as_lineno-$LINENO}: checking assembler for
> assembler for arm accepts context-specific architecture extensions" >&5
> -$as_echo_n "checking assembler for assembler for arm accepts
> context-specific architecture extensions... " >&6; }
> -if ${gcc_cv_as_arm_option_extensions+:} false; then :
> - $as_echo_n "(cached) " >&6
> -else
> - gcc_cv_as_arm_option_extensions=no
> - if test x$gcc_cv_as != x; then
> - $as_echo '.text
> - .thumb
> - .syntax unified
> - vmov.f32 s0, s1' > conftest.s
> - if { ac_try='$gcc_cv_as $gcc_cv_as_flags -march=armv8.1-m.main+mve -o
> conftest.o conftest.s >&5'
> - { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5
> - (eval $ac_try) 2>&5
> - ac_status=$?
> - $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5
> - test $ac_status = 0; }; }
> - then
> - gcc_cv_as_arm_option_extensions=yes
> - else
> - echo "configure: failed program was" >&5
> - cat conftest.s >&5
> - fi
> - rm -f conftest.o conftest.s
> - fi
> -fi
> -{ $as_echo "$as_me:${as_lineno-$LINENO}: result:
> $gcc_cv_as_arm_option_extensions" >&5
> -$as_echo "$gcc_cv_as_arm_option_extensions" >&6; }
> -if test $gcc_cv_as_arm_option_extensions = yes; then
> -
> -$as_echo "#define HAVE_GAS_ARM_EXTENDED_ARCH 1" >>confdefs.h
> -
> -fi
> -
> esac
> --- a/gcc/configure.ac
> +++ b/gcc/configure.ac
> case "$target" in
> amdgcn-* | gcn-*)
> [...]
> ;;
> - arm*)
> - gcc_GAS_CHECK_FEATURE([assembler for arm accepts context-specific
> architecture extensions],
> - gcc_cv_as_arm_option_extensions,
> - [-march=armv8.1-m.main+mve],
> - [.text
> - .thumb
> - .syntax unified
> - vmov.f32 s0, s1],,
> - [AC_DEFINE(HAVE_GAS_ARM_EXTENDED_ARCH, 1,
> - [Define if your Arm assembler permits context-specific feature
> extensions.])])
> esac
Grüße
Thomas
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634
München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas
Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht
München, HRB 106955
