On Sat, May 14, 2022 at 11:33:52PM +0200, Tobias Burnus wrote:
> libgomp/
> * libgomp.texi (OpenMP Implementation Status): Add 5.2 table.
>
> diff --git a/libgomp/libgomp.texi b/libgomp/libgomp.texi
> index b5e5fbb8cca..903b3cc8904 100644
> --- a/libgomp/libgomp.texi
> +++ b/libgomp/libgomp.texi
> @@ -283,21 +285,21 @@ The OpenMP 4.5 specification is fully supported.
> @code{append_args} @tab N @tab
> @item @code{dispatch} construct @tab N @tab
> @item device-specific ICV settings the environment variables @tab N @tab
> -@item assume directive @tab N @tab
> +@item @code{assume} directive @tab N @tab
> @item @code{nothing} directive @tab Y @tab
> @item @code{error} directive @tab Y @tab
The above change will clash with your change in the other patch, just
change it once, perhaps better in this patch.
> +@item @code{omp}/@code{ompx}/@code{ompx} sentinels and
> @code{omp_}/@code{ompx_} namespaces @tab N @tab
The second ompx should be omx.
Not really sure if there is anything to change for the above item, we do
handle omp sentinels, handling ompx and omx sentinels really depends on
whether we have some extension directives, when we don't, there is no
point supporting those... And for the namespaces, it is just a declaration
that the prefixes are reserved, we can't warn on them because we don't know
if they aren't actually the implementation of those extensions...
So perhaps N/A instead of N?
> +@item Clauses on @code{end} directive can be on directive @tab N @tab
> +@item Deprecation of no-argument @code{destroy} clause on @code{depobj} @tab
> N @tab
> +@item @code{linear} clause syntax changes and @code{step} modifier @tab N
> @tab
> +@item Deprecation of minus operator for reductions @tab N @tab
> +@item Deprecation of separating @code{map} modifiers without comma @tab N
> @tab
> +@item @code{declare mapper} with iterator and @code{present} modifiers @tab
> N @tab
> +@item If a matching mapped list item is not found in the data environment,
> the pointer retains its original value @tab N @tab
> +@item New @code{enter} clause replacing @code{to} on declare target
> directive @tab N @tab
See below for 2 bullets.
> +@item Extended list of directives permitted in Fortran pure procedures @tab
> N @tab
> +@item New @code{allocators} directive for Fortran @tab N @tab
> +@item Optional paired @code{end} directive with @code{dispatch} @tab N @tab
> +@item New @code{memspace} and @code{traits} modifiers for
> @code{uses_allocators} @tab N @tab
> +@item New @code{otherwise} clause replacing @code{default} on metadirectives
> @tab N @tab
Don't we want to split this into 2 bullets?
One for otherwise clause, one for deprecation of default clause?
Because I'm pretty sure that is how we are going to implement it, the
first one can be done very soon, the latter should be done as late as
possible (only when we have at least whole 5.1 or better most of 5.2 too
implemented).
> +@item Deprecation of delimited form of @code{declare target} @tab N @tab
> +@item Reproducible semantics changed for @code{order(concurrent)} @tab N @tab
> +@item @code{allocate} and @code{firstprivate} clauses on @code{scope} @tab N
> @tab
> +@item @code{ompt_callback_work} @tab N @tab
> +@item Extended map-type handling of @code{target enter/exit data} @tab N @tab
> +@item New @code{doacross} clause replacing @code{depend} with
> @code{sourch}/@code{sink} modifier @tab N @tab
s/sourch/source/ and see above for 2 bullets.
> +@item @code{omp_cur_iteration} keyword @tab N @tab
> +@end multitable
Otherwise LGTM.
Jakub
