On Tue, 03 May 2022 08:21:45 PDT (-0700), gcc-patches@gcc.gnu.org wrote:
On 4/29/2022 5:44 PM, Palmer Dabbelt wrote:Some tests check for fenv and then proceed to use fesetround() directly, but some platforms (at least RISC-V soft-float) have fenv but don't support rounding modes. This adds a DG check that fesetround() actually functions, which is then used by all the tests that call fesetround() explicitly. gcc/testsuite/ChangeLog * lib/target-supports.exp (check_effective_target_fenv_setround): New function. * gcc.dg/torture/fp-double-convert-float-1.c: Check fenv_fesetround. * gcc.dg/torture/fp-int-convert-float128-timode-3.c: Likewise. * gcc.dg/torture/fp-int-convert-timode-2.c: Likewise. * gcc.dg/torture/fp-int-convert-timode-3.c: Likewise. * gcc.dg/torture/fp-int-convert-timode-4.c: Likewise. * gcc.dg/torture/fp-uint64-convert-double-1.c: Likewise. * gcc.dg/torture/fp-uint64-convert-double-2.c: Likewise.I think the new effective target check needs to be documented in doc/sourcebuild.texi. With that change, this is OK.
Thanks, I sent a v3 and will commit it unless someone points out an issue.
