On Wed, 11 May 2022, Martin Liška wrote:
> May I please ping review for this?
There are various coding style issues in the patch; at least missing space
before '(' and '&&' at end of line (should be at start of line). It will
also need to be updated for .c files having been renamed to .cc in the GCC
source tree.
I'd also like to check that "if mingw-w64 is configured to target UCRT" is
not something that is necessarily known when GCC is built or from the
command-line options passed to GCC. Because ideally one might expect the
TARGET_OVERRIDES_FORMAT_ATTRIBUTES / TARGET_OVERRIDES_FORMAT_INIT
definitions to handle things appropriately conditionally, so that printf
attributes are handled as gnu_printf for the "if mingw-w64 is configured
to target UCRT" case. Disregarding a built-in format attribute when one
is also specified explicitly in the header, even though the two are not
exactly equivalent attributes, as in this patch, seems more like the right
approach in the case where the attributes in installed header (at the time
GCC is run, not the time it is built) *are* the way in which GCC gets the
"configured to target UCRT" information - as opposed to it being something
available before the header is parsed.
--
Joseph S. Myers
jos...@codesourcery.com
