Detection of references to unset (uninitialized) objects requires calls
to Check_Unset_Reference on every subexpression of a composite statement
and expression. For declare and qualified expressions this was done only
when they occurred within another composite statement/expression.
Tested on x86_64-pc-linux-gnu, committed on trunk
gcc/ada/
* sem_res.adb (Resolve_Declare_Expression): Check expression for
references to unset objects.
(Resolve_Qualified_Expression): Likewise.
* sem_warn.adb (Check_Unset_Reference): Remove handling of
declare and qualified expressions; clarify comment for type
conversions.diff --git a/gcc/ada/sem_res.adb b/gcc/ada/sem_res.adb
--- a/gcc/ada/sem_res.adb
+++ b/gcc/ada/sem_res.adb
@@ -7673,6 +7673,7 @@ package body Sem_Res is
end if;
Resolve (Expr, Typ);
+ Check_Unset_Reference (Expr);
end Resolve_Declare_Expression;
-----------------------------------------
@@ -10586,6 +10587,7 @@ package body Sem_Res is
begin
Resolve (Expr, Target_Typ);
+ Check_Unset_Reference (Expr);
-- A qualified expression requires an exact match of the type, class-
-- wide matching is not allowed. However, if the qualifying type is
diff --git a/gcc/ada/sem_warn.adb b/gcc/ada/sem_warn.adb
--- a/gcc/ada/sem_warn.adb
+++ b/gcc/ada/sem_warn.adb
@@ -2244,13 +2244,11 @@ package body Sem_Warn is
Check_Unset_Reference (Pref);
end;
- -- For type conversions, qualifications, or expressions with actions,
- -- examine the expression.
+ -- Type conversions can appear in assignment statements both
+ -- as variable names and as expressions. We examine their own
+ -- expressions only when processing their parent node.
- when N_Expression_With_Actions
- | N_Qualified_Expression
- | N_Type_Conversion
- =>
+ when N_Type_Conversion =>
Check_Unset_Reference (Expression (N));
-- For explicit dereference, always check prefix, which will generate
