On Thu, May 5, 2022 at 8:59 PM Iain Sandoe via Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > > > > > On 5 May 2022, at 19:50, Martin Liška <mli...@suse.cz> wrote: > > > > On 5/5/22 20:35, Andrew Pinski wrote: > >> GCC_VERSION will be 0 if GCC is not being used. > >> So you need to audit these better really. > > > > Ah, I see. So it basically means all the non-GCC conditional > > code needs to remain and I can replace > > #if GCC_VERSION >= X_Y_Z with #ifdef __GNUC__ > > I think several non-GCC compilers define __GNUC__ so that depends on what you > intend.
Indeed. Other compilers are careful in what GCC version they announce specifically to match up with its extensions. They might still support C++11 when they do not support all extensions of GCC 4.8. So I think we should drop this patch. Richard. > Iain > > > > > Am I correct? > > Martin >
