Re: libgomp GCN plugin: Clean up unused references to system-provided HSA Runtime library (was: [PATCH 1/4] Remove build dependence on HSA run-time)

[Andrew Stubbs]

On 06/04/2022 11:02, Thomas Schwinge wrote:

Hi!

On 2021-01-14T15:50:23+0100, I wrote:

I'm raising here an issue with HSA libgomp plugin code changes from a
while ago.  While HSA is now no longer relevant for GCC master branch,
the same code has also been copied into the GCN libgomp plugin.

Here is another small clean-up patch (to enable further clean-up):

This is commit b8d89b03db5f212919e4571671ebb4f5f8b1e19d (r242749) "Remove
build dependence on HSA run-time":

On 2016-11-22T14:27:44+0100, Martin Jambor <mjam...@suse.cz> wrote:

--- a/libgomp/plugin/configfrag.ac
+++ b/libgomp/plugin/configfrag.ac

@@ -195,8 +183,8 @@ if test x"$enable_offload_targets" != x; then
              tgt_name=hsa
              PLUGIN_HSA=$tgt
              PLUGIN_HSA_CPPFLAGS=$HSA_RUNTIME_CPPFLAGS
-            PLUGIN_HSA_LDFLAGS="$HSA_RUNTIME_LDFLAGS $HSA_KMT_LDFLAGS"
-            PLUGIN_HSA_LIBS="-lhsa-runtime64 -lhsakmt"
+            PLUGIN_HSA_LDFLAGS="$HSA_RUNTIME_LDFLAGS"
+            PLUGIN_HSA_LIBS="-ldl"

So this switched from directly linking against 'libhsa-runtime64.so' to a
'libdl'-based runtime linking variant.

(Not intending to change anything regarding that.)

Given the 'PLUGIN_HSA_LIBS' change cited above, OK to push the attached
"libgomp GCN plugin: Clean up unused references to system-provided HSA
Runtime library"?

OK.

Andrew