Le 25/04/2022 à 14:12, Jakub Jelinek a écrit :
On Mon, Apr 25, 2022 at 01:38:25PM +0200, Mikael Morin wrote:
I have just pushed the attached fix for two UNRESOLVED checks at -O0 that I
hadn’t seen.
I don't like forcing of DSE in -O0 compilation, wouldn't it be better
to just not check the dse dump at -O0 like in the following patch?
Certainly better. I actually looked for something alike already
existing before trying to write a conditional in the dg-final code and
finally deciding to go the easy way.
Even better would be to check that the z._data = stores are both present
in *.optimized dump, but that doesn't really work at -O2 or above because
we inline the functions and optimize it completely away (both the stores
and corresponding reads).
Yes, and global optimization is already checked by test execution anyway.
The first hunk is needed so that __OPTIMIZE__ effective target works in
Fortran testsuite, otherwise one gets a pedantic error and __OPTIMIZE__
is considered not to match at all.
Maybe worth putting as code comment.
OK from my side, thanks.
