On Mon, Mar 21, 2022 at 02:14:08PM -0400, David Edelsohn wrote: > On Mon, Mar 21, 2022 at 5:13 AM Jiufu Guo <guoji...@linux.ibm.com> wrote: > > There is a rare corner case: where __vector is followed only with ";" > > and near the end of the file.
> This is okay. Maybe a tweak to the comment, see below. This whole function could use some restructuring / rewriting to make clearer what it actually does. See the function comment: /* Called to decide whether a conditional macro should be expanded. Since we have exactly one such macro (i.e, 'vector'), we do not need to examine the 'tok' parameter. */ ... followed by 17 uses of "tok". Yes, some of those overwrite the function argument, but that doesn't make it any better! :-P Some factoring would help, too, perhaps. Segher
