On Thu, 17 Mar 2022 at 20:44, Thomas Rodgers wrote: > > Looks ok to me. I just am curious, does the change to src/c++17/fs_path.cc > need to be part of this change (It's not obvious to me that it is related to > the other changes in the patch).
It's related. fs_path.cc uses std::array but was not including <array> directly, it was accidentally relying on it being there via <algorithm>. After this change, <algorithm> doesn't include <functional>, so doesn't include <array> and so fs_path.cc needs to be fixed.