> Bootstrapped/regtested on {x86_64,i686,powerpc64le,aarch64,s390x}-linux,
> ok for trunk?
>
> 2022-03-13 Jakub Jelinek <ja...@redhat.com>
>
> PR rtl-optimization/104814
> * ifcvt.cc (find_if_case_1, find_if_case_2): Punt if test_bb
> doesn't end with onlyjump_p.
>
> * gcc.c-torture/execute/pr104814.c: New test.
>
> --- gcc/ifcvt.cc.jj 2022-02-09 12:55:50.750773751 +0100
> +++ gcc/ifcvt.cc 2022-03-11 17:30:44.248855063 +0100
> @@ -5259,6 +5259,10 @@ find_if_case_1 (basic_block test_bb, edg
> && CROSSING_JUMP_P (BB_END (else_bb))))
> return FALSE;
>
> + /* Verify test_bb ends in a conditional jump with no other side-effects.
> */ + if (!BB_END (test_bb) || !onlyjump_p (BB_END (test_bb)))
> + return FALSE;
> +
> /* THEN has one successor. */
> if (!single_succ_p (then_bb))
> return FALSE;
> @@ -5380,6 +5384,10 @@ find_if_case_2 (basic_block test_bb, edg
> && CROSSING_JUMP_P (BB_END (else_bb))))
> return FALSE;
>
> + /* Verify test_bb ends in a conditional jump with no other side-effects.
> */ + if (!BB_END (test_bb) || !onlyjump_p (BB_END (test_bb)))
> + return FALSE;
> +
> /* ELSE has one successor. */
> if (!single_succ_p (else_bb))
> return FALSE;
Are the !BB_END tests really necessary? cond_exec_process_if_block has the
same test on onlyjump_p without it. Likewise for noce_find_if_block.
--
Eric Botcazou
