On Fri, 11 Mar 2022, Krishna Narayanan via Gcc-patches wrote:
> Hello,
> The following is a patch for the PR92209,which gives a warning when
> the function prototype does not specify its argument type.In this
> patch there has been a change in the warning message displayed for
> -Wstrict-prototypes to specify its argument types.I have also added
> the testcase for it.
> Regtested on x86_64,OK for commit? Please do review it.
Why do you think your proposed wording is better than the existing
wording? I think the existing wording is accurate and the proposed
wording is inaccurate - "must specify the argument types" is not an
accurate description of any requirement in the C language, using "must" at
all generally seems questionable in the wording of a warning message.
Also, I don't think this change is anything to do with the PR you mention
("Imprecise column number for -Wstrict-prototypes"), so it's wrong to
mention that PR number in the proposed commit message.
--
Joseph S. Myers
jos...@codesourcery.com
