On Tue, 8 Mar 2022, H.J. Lu wrote:
> On Tue, Mar 8, 2022 at 9:35 AM Jakub Jelinek <ja...@redhat.com> wrote:
> >
> > On Tue, Mar 08, 2022 at 08:09:25AM -0800, H.J. Lu wrote:
> > > > Ok. So, what do you think about replacing the libgcc/ part of your
> > > > patch
> > > > with that
> > > > /* __builtin_eh_return can't handle stack realignment, so disable SSE in
> > > > 32-bit libgcc functions that call it. */
> > > > #ifndef __x86_64__
> > > > #define LIBGCC2_UNWIND_ATTRIBUTE __attribute__((target ("no-sse")))
> > > > #endif
> > > > ?
> > >
> > > Yes, it should work.
> >
> > So, how do we move on with this?
> > I can't self-approve my own patch, so can anyone please ack the following
> > provided it passes bootstraps/regtests ({x86_64,i686}-linux) that are
> > currently pending?
> >
> > That can go in independently from your patch, and if it is committed,
> > your V3 patch with the libgcc/ hunks removed is preapproved for trunk.
> >
> > 2022-03-08 Jakub Jelinek <ja...@redhat.com>
> >
> > PR target/104781
> > * config/i386/i386.h (LIBGCC2_UNWIND_ATTRIBUTE): Define for ia32.
> >
> > --- gcc/config/i386/i386.h.jj 2022-02-25 12:06:45.535493490 +0100
> > +++ gcc/config/i386/i386.h 2022-03-08 11:20:43.207043370 +0100
> > @@ -2848,6 +2848,12 @@ extern enum attr_cpu ix86_schedule;
> > #define NUM_X86_64_MS_CLOBBERED_REGS 12
> > #endif
> >
> > +/* __builtin_eh_return can't handle stack realignment, so disable SSE in
> > + 32-bit libgcc functions that call it. */
> > +#ifndef __x86_64__
> > +#define LIBGCC2_UNWIND_ATTRIBUTE __attribute__((target ("no-sse")))
> > +#endif
> > +
> > /*
> > Local variables:
> > version-control: t
> >
> >
> > Jakub
> >
>
> LGTM.
I wonder if this is a good case for general-regs-only instead? At
least no-sse cannot be functionally equivalent (since then we would
not have needed general-regs-only ...).
Richard.
