Hi! On 2022-03-01T17:46:20+0100, I wrote: > On 2022-01-13T10:54:16+0100, I wrote: >> --- a/gcc/omp-oacc-kernels-decompose.cc >> +++ b/gcc/omp-oacc-kernels-decompose.cc
>> @@ -842,6 +843,9 @@ maybe_build_inner_data_region (location_t loc, gimple >> *body, >> inner_data_clauses = new_clause; >> >> prev_mapped_var = v; >> + >> + /* See <https://gcc.gnu.org/PR100280>. */ >> + TREE_ADDRESSABLE (v) = 1; >> } >> } > > So, that's too simple. ;-) [...] > We're after gimplification, and must not just set 'TREE_ADDRESSABLE', > because that may easily violate GIMPLE invariants, leading to ICEs later. > There are a few open PRs Pushed to master branch commit 741859b390c042755e9379f8061a157e5af378b6 "Add 'c-c++-common/goacc/kernels-decompose-pr104132-1.c' [PR104132]", see attached. Grüße Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955
>From 741859b390c042755e9379f8061a157e5af378b6 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge <tho...@codesourcery.com> Date: Wed, 19 Jan 2022 22:28:55 +0100 Subject: [PATCH] Add 'c-c++-common/goacc/kernels-decompose-pr104132-1.c' [PR104132] ..., currently XFAILed with 'dg-ice'. PR middle-end/104132 gcc/testsuite/ * c-c++-common/goacc/kernels-decompose-pr104132-1.c: New file. --- .../goacc/kernels-decompose-pr104132-1.c | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 gcc/testsuite/c-c++-common/goacc/kernels-decompose-pr104132-1.c diff --git a/gcc/testsuite/c-c++-common/goacc/kernels-decompose-pr104132-1.c b/gcc/testsuite/c-c++-common/goacc/kernels-decompose-pr104132-1.c new file mode 100644 index 00000000000..4fbfdd81e15 --- /dev/null +++ b/gcc/testsuite/c-c++-common/goacc/kernels-decompose-pr104132-1.c @@ -0,0 +1,38 @@ +/* { dg-additional-options "--param openacc-kernels=decompose" } */ + +/* { dg-additional-options "-fchecking" } + { dg-ice TODO } + { dg-prune-output {k = 0 \+ \.offset\.[0-9]+;} } + { dg-prune-output {k = 0 \+ 2;} } + { dg-prune-output {during IPA pass: \*free_lang_data} } */ + +/* { dg-additional-options "-fopt-info-all-omp" } */ + +/* { dg-additional-options "--param=openacc-privatization=noisy" } + Prune a few: uninteresting, and potentially varying depending on GCC configuration (data types): + { dg-prune-output {note: variable 'D\.[0-9]+' declared in block isn't candidate for adjusting OpenACC privatization level: not addressable} } */ + +int arr_0; + +void +foo (void) +{ +#pragma acc kernels /* { dg-line l_compute1 } */ + /* { dg-note {variable 'k' declared in block is candidate for adjusting OpenACC privatization level} {} { target *-*-* } l_compute1 } */ + { + int k; + + /* { dg-note {forwarded loop nest in OpenACC 'kernels' region to 'parloops' for analysis} {} { target *-*-* } .+1 } */ +#pragma acc loop /* { dg-line l_loop_k1 } */ + /* { dg-note {variable 'k' in 'private' clause is candidate for adjusting OpenACC privatization level} {} { target *-*-* } l_loop_k1 } */ + for (k = 0; k < 2; k++) + arr_0 = k; + + /* { dg-note {forwarded loop nest in OpenACC 'kernels' region to 'parloops' for analysis} {} { target *-*-* } .+1 } */ +#pragma acc loop /* { dg-line l_loop_k2 } */ + /* { dg-note {variable 'k' in 'private' clause is candidate for adjusting OpenACC privatization level} {} { target *-*-* } l_loop_k2 } */ + for (k = 0; k < 2; k++) + arr_0 = k; + } +} +/* { dg-bogus {error: non-register as LHS of binary operation} {} { xfail *-*-* } .-1 } */ -- 2.34.1