Re: [PATCH 0/3] Enable pointer_query caching throughout.

[Martin Sebor via Gcc-patches]

On 2/3/22 17:18, David Edelsohn wrote:

On Thu, Feb 3, 2022 at 6:09 PM Martin Sebor <mse...@gmail.com> wrote:

On 2/3/22 15:56, David Edelsohn wrote:

This series of patches has exploded memory usage and I can no longer
bootstrap GCC on AIX.

As with the Ranger problem exposed by Aldy's patch last September,
something is not freeing memory.

Even on systems where GCC still bootstrap, this excessive memory usage
severely damages GCC compile performance.

Does the change below by any chance make a difference?  (It's just
a hunch, I haven't tested it beyond quickly building stage 1 and
running a few tests.)

Hi, Martin

Thanks for the quick response.  Yes, I am able to restore bootstrap on
AIX (32 bit) with the change.

Let me finish testing it and if all goes well commit it later tonight.

Thanks for the confirmation!

Martin

Thanks, David

Martin


diff --git a/gcc/pointer-query.h b/gcc/pointer-query.h
index 4c725eeaf34..801a240c38d 100644
--- a/gcc/pointer-query.h
+++ b/gcc/pointer-query.h
@@ -164,9 +164,9 @@ class pointer_query
     struct cache_type
     {
       /* 1-based indices into cache.  */
-    vec<unsigned> indices;
+    auto_vec<unsigned> indices;
       /* The cache itself.  */
-    vec<access_ref> access_refs;
+    auto_vec<access_ref> access_refs;
     };

   public: