Following on from GCC 11 patch g:f31ddad8ac8, this one gives clean
guality.exp test results for aarch64-linux-gnu with modern gdb
(this time gdb 11.2).
The justification is the same as previously:
------
For people using older gdbs, it will trade one set of noisy results for
another set. I still think it's better to have the xfails based on
one “clean” and “modern” run rather than have FAILs and XPASSes for
all runs.
It's hard to tell which of these results are aarch64-specific and
which aren't. If other target maintainers want to do something similar,
and are prepared to assume the same gdb version, then it should become
clearer over time which ones are target-specific and which aren't.
There are no new skips here, so changes in test results will still
show up as XPASSes.
I've not analysed the failures or filed PRs for them. In some
ways the guality directory itself seems like the best place to
start looking for xfails, if someone's interested in working
in this area.
------
gcc/testsuite/
* gcc.dg/guality/ipa-sra-1.c: Update aarch64*-*-* xfails.
* gcc.dg/guality/pr54519-1.c: Likewise.
* gcc.dg/guality/pr54519-3.c: Likewise.
---
gcc/testsuite/gcc.dg/guality/ipa-sra-1.c | 2 +-
gcc/testsuite/gcc.dg/guality/pr54519-1.c | 6 +++---
gcc/testsuite/gcc.dg/guality/pr54519-3.c | 6 +++---
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/gcc/testsuite/gcc.dg/guality/ipa-sra-1.c
b/gcc/testsuite/gcc.dg/guality/ipa-sra-1.c
index 5434b3d7665..9ef4eac93a7 100644
--- a/gcc/testsuite/gcc.dg/guality/ipa-sra-1.c
+++ b/gcc/testsuite/gcc.dg/guality/ipa-sra-1.c
@@ -12,7 +12,7 @@ static int __attribute__((noinline))
bar (int i, int k)
{
asm ("" : "+r" (i));
- use (i); /* { dg-final { gdb-test . "k" "3" { xfail *-*-* } } }
*/
+ use (i); /* { dg-final { gdb-test . "k" "3" { xfail { ! {
aarch64*-*-* && { any-opts "-O0" "-O1" "-Og" } } } } } } */
return 6;
}
diff --git a/gcc/testsuite/gcc.dg/guality/pr54519-1.c
b/gcc/testsuite/gcc.dg/guality/pr54519-1.c
index 81703eb1744..5880d9b4f57 100644
--- a/gcc/testsuite/gcc.dg/guality/pr54519-1.c
+++ b/gcc/testsuite/gcc.dg/guality/pr54519-1.c
@@ -18,9 +18,9 @@ fn2 (int x, int y, int z)
fn1 (x); /* { dg-final { gdb-test .+2 "x" "36" } } */
if (x == 36) /* { dg-final { gdb-test .+1 "y" "25" { xfail {
aarch64*-*-* && { any-opts "-flto" } } } } } */
fn1 (x); /* { dg-final { gdb-test . "z" "6" { xfail {
aarch64*-*-* && { any-opts "-flto" } } } } } */
- fn1 (x); /* { dg-final { gdb-test .+2 "x" "98" } } */
- if (x == 98) /* { dg-final { gdb-test .+1 "y" "117" { xfail {
aarch64*-*-* && { any-opts "-flto" } } } } } */
- fn1 (x); /* { dg-final { gdb-test . "z" "8" { xfail {
aarch64*-*-* && { any-opts "-flto" } } } } } */
+ fn1 (x); /* { dg-final { gdb-test .+2 "x" "98" { xfail {
aarch64*-*-* && { any-opts "-Os" } } } } } */
+ if (x == 98) /* { dg-final { gdb-test .+1 "y" "117" { xfail {
aarch64*-*-* && { any-opts "-Os" "-flto" } } } } } */
+ fn1 (x); /* { dg-final { gdb-test . "z" "8" { xfail {
aarch64*-*-* && { any-opts "-Os" "-flto" } } } } } */
fn1 (x);
fn1 (x + a);
}
diff --git a/gcc/testsuite/gcc.dg/guality/pr54519-3.c
b/gcc/testsuite/gcc.dg/guality/pr54519-3.c
index fabab963d72..9c18993e7a9 100644
--- a/gcc/testsuite/gcc.dg/guality/pr54519-3.c
+++ b/gcc/testsuite/gcc.dg/guality/pr54519-3.c
@@ -18,9 +18,9 @@ fn2 (int x, int y, int z)
fn1 (x); /* { dg-final { gdb-test .+2 "x" "36" } } */
if (x == 36) /* { dg-final { gdb-test .+1 "y" "25" { xfail {
aarch64*-*-* && { any-opts "-flto" } } } } } */
fn1 (x); /* { dg-final { gdb-test . "z" "6" { xfail {
aarch64*-*-* && { any-opts "-flto" } } } } } */
- fn1 (x); /* { dg-final { gdb-test .+2 "x" "98" } } */
- if (x == 98) /* { dg-final { gdb-test .+1 "y" "117" { xfail {
aarch64*-*-* && { any-opts "-flto" } } } } } */
- fn1 (x); /* { dg-final { gdb-test . "z" "8" { xfail {
aarch64*-*-* && { any-opts "-flto" } } } } } */
+ fn1 (x); /* { dg-final { gdb-test .+2 "x" "98" { xfail {
aarch64*-*-* && { any-opts "-Os" } } } } } */
+ if (x == 98) /* { dg-final { gdb-test .+1 "y" "117" { xfail {
aarch64*-*-* && { any-opts "-Os" "-flto" } } } } } */
+ fn1 (x); /* { dg-final { gdb-test . "z" "8" { xfail {
aarch64*-*-* && { any-opts "-Os" "-flto" } } } } } */
fn1 (x);
fn1 (x + a);
}
--
2.25.1
