Re: s390: Fix bootstrap -Wformat-diag errors

[Martin Sebor via Gcc-patches]

On 2/2/22 09:35, Robin Dapp via Gcc-patches wrote:

Hi,

this fixes the s390 bootstrap errors caused by -Werror=format-diag.  It
simply splits the problematic format strings.

Either this:

  error ("%<attribute(target(\"%s\"))%> is unknown", orig_p);

or this would be better:

  error ("attribute %<target(\"%s\")%> is unknown", orig_p);

The %< %> directives will render it in single quotes like keywords and
identifiers.  Using %qs would render it in double quotes like a string,
which wouldn't be quite right.

Martin

Bootstrapped and regtested with -march=z15.

Is it OK?

Regards
  Robin

--

gcc/ChangeLog:

         * config/s390/s390.cc (s390_valid_target_attribute_inner_p): Split
         format strings.