On Fri, Jan 28, 2022 at 11:50:21AM -0600, Bill Schmidt wrote:
> When introducing the new built-in support, I tried to match as many
> existing error messages as possible.  One common form was "argument X must
> be a Y-bit unsigned literal".  Another was "argument X must be a literal
> between X' and  Y', inclusive".  During reviews, Segher requested that I
> eventually convert all messages of the first form into the second form for
> consistency.  That's what this patch does, replacing all <x>-form
> constraints (first form) with <x,y>-form constraints (second form).

Well, I asked for the error messages to be clearer and more consistent
like that.  I don't think changing our source code like this is an
improvement (*we* know what a 5-bit signed number is).  Do you think
after your patch it is clearer and we will make fewer errors?


Segher

Reply via email to