on 2022/1/27 上午1:57, Segher Boessenkool wrote: > Hi! > > On Wed, Jan 26, 2022 at 10:26:45AM +0800, Kewen.Lin wrote: >> on 2022/1/14 上午12:31, David Edelsohn wrote: >> Yeah, but IMHO it still can confuse new comers at first glance. > > Yes, or at least cause to read (well, grep) the whole backend and > scratch heads. > >>>> 2) Bootstrapped and tested one below patch to remove all the code using >>>> RS6000_CONSTRAINT_v on powerpc64le-linux-gnu P10 and P9, >>>> powerpc64-linux-gnu P8 and P7 with no regressions. > >>> I would prefer that we not make gratuitous changes to this code, but >>> maybe Segher has a different opinion. >> >> Thanks David for the comments! >> >> Hi Segher, what's your preference on this? > > I like your original patch better. But for stage 1, sorry. >
Thanks Segher! Is it ok to commit it then? Or I'll repost this once next stage1 starts. BR, Kewen > Indeed using ALTIVEC_REGS directly in the define_regiater_constraint > works fine, but it isn't as clear as it could be that is correct. > > > Segher >
