On Mon, Jan 24, 2022 at 05:36:58PM -0500, Marek Polacek wrote:
> The implementation is done by using the new EnumSet feature.
>
> PR preprocessor/104030
>
> gcc/c-family/ChangeLog:
>
> * c.opt (Wbidi-chars): Mark as EnumSet. Also accept =ucn.
>
> gcc/ChangeLog:
>
> * doc/invoke.texi: Update documentation for -Wbidi-chars.
>
> libcpp/ChangeLog:
>
> * include/cpplib.h (enum cpp_bidirectional_level): Add
> bidirectional_ucn. Set values explicitly.
> * internal.h (cpp_reader): Adjust warn_bidi_p.
> * lex.cc (maybe_warn_bidi_on_close): Don't warn about UCNs
> unless UCN checking is on.
> (maybe_warn_bidi_on_char): Likewise.
>
> gcc/testsuite/ChangeLog:
>
> * c-c++-common/Wbidi-chars-10.c: Turn on UCN checking.
> * c-c++-common/Wbidi-chars-11.c: Likewise.
> * c-c++-common/Wbidi-chars-14.c: Likewise.
> * c-c++-common/Wbidi-chars-16.c: Likewise.
> * c-c++-common/Wbidi-chars-17.c: Likewise.
> * c-c++-common/Wbidi-chars-4.c: Likewise.
> * c-c++-common/Wbidi-chars-5.c: Likewise.
> * c-c++-common/Wbidi-chars-6.c: Likewise.
> * c-c++-common/Wbidi-chars-7.c: Likewise.
> * c-c++-common/Wbidi-chars-8.c: Likewise.
> * c-c++-common/Wbidi-chars-9.c: Likewise.
> * c-c++-common/Wbidi-chars-ranges.c: Likewise.
> * c-c++-common/Wbidi-chars-18.c: New test.
> * c-c++-common/Wbidi-chars-19.c: New test.
> * c-c++-common/Wbidi-chars-20.c: New test.
> * c-c++-common/Wbidi-chars-21.c: New test.
> * c-c++-common/Wbidi-chars-22.c: New test.
> * c-c++-common/Wbidi-chars-23.c: New test.
LGTM, thanks.
Jakub
