On Sun, Jan 23, 2022 at 10:06:24AM +0100, Uros Bizjak wrote:
> > 2022-01-22  Jakub Jelinek  <ja...@redhat.com>
> >
> >         * config/linux.h (OPTION_GLIBC_P, OPTION_UCLIBC_P,
> >         OPTION_BIONIC_P, OPTION_MUSL_P): Define.
> >         (OPTION_GLIBC, OPTION_UCLIBC, OPTION_BIONIC, OPTION_MUSL): Redefine
> >         using OPTION_*_P macros.
> >         * config/alpha/linux.h (OPTION_GLIBC_P, OPTION_UCLIBC_P,
> >         OPTION_BIONIC_P, OPTION_MUSL_P): Define.
> >         (OPTION_GLIBC, OPTION_UCLIBC, OPTION_BIONIC, OPTION_MUSL): Redefine
> >         using OPTION_*_P macros.
> >         * config/rs6000/linux.h (OPTION_GLIBC_P, OPTION_UCLIBC_P,
> >         OPTION_BIONIC_P, OPTION_MUSL_P): Define.
> >         (OPTION_GLIBC, OPTION_UCLIBC, OPTION_BIONIC, OPTION_MUSL): Redefine
> >         using OPTION_*_P macros.
> >         * config/rs6000/linux64.h (OPTION_GLIBC_P, OPTION_UCLIBC_P,
> >         OPTION_BIONIC_P, OPTION_MUSL_P): Define.
> >         (OPTION_GLIBC, OPTION_UCLIBC, OPTION_BIONIC, OPTION_MUSL): Redefine
> >         using OPTION_*_P macros.
> >         * config/fuchsia.h (OPTION_MUSL_P): Redefine.
> >         * config/glibc-stdint.h (OPTION_MUSL_P): Define if not defined.
> >         * common/config/s390/s390-common.cc (s390_supports_split_stack): 
> > Re-add
> >         ATTRIBUTE_UNUSED to opts parameter.  If OPTION_GLIBC_P is defined, 
> > use
> >         OPTION_GLIBC_P (opts) as condition, otherwise assume if (false).
> >         * common/config/i386/i386-common.cc (ix86_supports_split_stack): If
> >         OPTION_GLIBC_P is defined use !OPTION_GLIBC_P (opts) as condition,
> >         otherwise assume if (true).
> 
> I wonder why every target defines its own set of #defines. I'd expect
> that they include toplevel gcc/config/linux.h and inherit these
> defines from it.

Not every target, most of the Linux targets do use config/linux.h,
just ppc* and alpha haven't been converted to do so.
It would be nice to have that done at some point, but to me that
looks like stage1 task rather than stage4.

        Jakub

Reply via email to