Hi!
On 2022-01-05T12:06:12+0100, Martin Liška <mli...@suse.cz> wrote:
> The patch is about small refactoring of the plugin.
Yay!
> include/ChangeLog:
>
> * plugin-api.h (enum ld_plugin_tag): Do not set implicit enum
> values.
I did wonder whether the original idea there would've been to fixate
these values, which are part of a public API/ABI? (..., and thus, even
if the values don't change now if not assigning them explicitly, maybe
that should still be kept as-is, for robustness.) But then, all other
'enum's in 'include/plugin-api.h' also don't assign explicit 'enum'
values, so probably there's indeed no reason for this one to be
different.
Grüße
Thomas
> --- a/include/plugin-api.h
> +++ b/include/plugin-api.h
> @@ -487,40 +487,40 @@ enum ld_plugin_level
>
> enum ld_plugin_tag
> {
> - LDPT_NULL = 0,
> - LDPT_API_VERSION = 1,
> - LDPT_GOLD_VERSION = 2,
> - LDPT_LINKER_OUTPUT = 3,
> - LDPT_OPTION = 4,
> - LDPT_REGISTER_CLAIM_FILE_HOOK = 5,
> - LDPT_REGISTER_ALL_SYMBOLS_READ_HOOK = 6,
> - LDPT_REGISTER_CLEANUP_HOOK = 7,
> - LDPT_ADD_SYMBOLS = 8,
> - LDPT_GET_SYMBOLS = 9,
> - LDPT_ADD_INPUT_FILE = 10,
> - LDPT_MESSAGE = 11,
> - LDPT_GET_INPUT_FILE = 12,
> - LDPT_RELEASE_INPUT_FILE = 13,
> - LDPT_ADD_INPUT_LIBRARY = 14,
> - LDPT_OUTPUT_NAME = 15,
> - LDPT_SET_EXTRA_LIBRARY_PATH = 16,
> - LDPT_GNU_LD_VERSION = 17,
> - LDPT_GET_VIEW = 18,
> - LDPT_GET_INPUT_SECTION_COUNT = 19,
> - LDPT_GET_INPUT_SECTION_TYPE = 20,
> - LDPT_GET_INPUT_SECTION_NAME = 21,
> - LDPT_GET_INPUT_SECTION_CONTENTS = 22,
> - LDPT_UPDATE_SECTION_ORDER = 23,
> - LDPT_ALLOW_SECTION_ORDERING = 24,
> - LDPT_GET_SYMBOLS_V2 = 25,
> - LDPT_ALLOW_UNIQUE_SEGMENT_FOR_SECTIONS = 26,
> - LDPT_UNIQUE_SEGMENT_FOR_SECTIONS = 27,
> - LDPT_GET_SYMBOLS_V3 = 28,
> - LDPT_GET_INPUT_SECTION_ALIGNMENT = 29,
> - LDPT_GET_INPUT_SECTION_SIZE = 30,
> - LDPT_REGISTER_NEW_INPUT_HOOK = 31,
> - LDPT_GET_WRAP_SYMBOLS = 32,
> - LDPT_ADD_SYMBOLS_V2 = 33
> + LDPT_NULL,
> + LDPT_API_VERSION,
> + LDPT_GOLD_VERSION,
> + LDPT_LINKER_OUTPUT,
> + LDPT_OPTION,
> + LDPT_REGISTER_CLAIM_FILE_HOOK,
> + LDPT_REGISTER_ALL_SYMBOLS_READ_HOOK,
> + LDPT_REGISTER_CLEANUP_HOOK,
> + LDPT_ADD_SYMBOLS,
> + LDPT_GET_SYMBOLS,
> + LDPT_ADD_INPUT_FILE,
> + LDPT_MESSAGE,
> + LDPT_GET_INPUT_FILE,
> + LDPT_RELEASE_INPUT_FILE,
> + LDPT_ADD_INPUT_LIBRARY,
> + LDPT_OUTPUT_NAME,
> + LDPT_SET_EXTRA_LIBRARY_PATH,
> + LDPT_GNU_LD_VERSION,
> + LDPT_GET_VIEW,
> + LDPT_GET_INPUT_SECTION_COUNT,
> + LDPT_GET_INPUT_SECTION_TYPE,
> + LDPT_GET_INPUT_SECTION_NAME,
> + LDPT_GET_INPUT_SECTION_CONTENTS,
> + LDPT_UPDATE_SECTION_ORDER,
> + LDPT_ALLOW_SECTION_ORDERING,
> + LDPT_GET_SYMBOLS_V2,
> + LDPT_ALLOW_UNIQUE_SEGMENT_FOR_SECTIONS,
> + LDPT_UNIQUE_SEGMENT_FOR_SECTIONS,
> + LDPT_GET_SYMBOLS_V3,
> + LDPT_GET_INPUT_SECTION_ALIGNMENT,
> + LDPT_GET_INPUT_SECTION_SIZE,
> + LDPT_REGISTER_NEW_INPUT_HOOK,
> + LDPT_GET_WRAP_SYMBOLS,
> + LDPT_ADD_SYMBOLS_V2,
> };
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634
München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas
Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht
München, HRB 106955
