On Thu, Jan 13 2022, Jakub Jelinek via Gcc-patches wrote: > On Thu, Jan 13, 2022 at 12:20:57PM +0100, Martin Liška wrote: >> On 1/13/22 12:14, Richard Biener wrote: >> > But please make sure all intermediate revs will still build. >> >> That's not possible :) I don't it's a good idea mixing .cc renaming >> and changes in that files. > > I think it is possible, but would require more work. > Comments in the files don't matter for sure, and in the Makefiles we > could do (just one random file can be checked): > ifeq (,$(wildcard $(srcdir)/expr.cc)) > what we used to do > else > what we want to do newly > endif > A commit that changes the Makefiles that way comes first, then > the renaming commit, then a commit that removes those ifeq ... else > and endif lines. >
I would expect that the problematic case is only when you modify a file that you also rename. Is there any such file where we do more than adjust comments, where the contents modifications are essential for bootstrap too? I would expect that modifications in Makefiles, configure-scripts etc could go in the same commit as the renames and these could be then followed up with comments adjustments and similar. But it would be more work, so I guess just using git bisect skip if bisection ever lands in the middle of this is acceptable in this special case too. Martin
