Hi Andrew, > On 24 Dec 2021, at 10:51, Andrew Pinski <pins...@gmail.com> wrote: > > On Fri, Dec 24, 2021 at 2:47 AM Iain Sandoe via Gcc-patches > <gcc-patches@gcc.gnu.org> wrote: >> >>
>> @@ -3336,6 +3336,7 @@ darwin_override_options (void) >> (s)he knows why... */ > > I see you already pushed this code, it might be a good idea to also > change (s)he to just they in the above comment too. done as below, thanks, Iain [pushed] Darwin: Amend a comment to be more inclusive [NFC]. As per title. Signed-off-by: Iain Sandoe <i...@sandoe.co.uk> gcc/ChangeLog: * config/darwin.c (darwin_override_options): Make a comment more inclusive. --- gcc/config/darwin.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gcc/config/darwin.c b/gcc/config/darwin.c index 5045b68e8af..c8e8b9d9f86 100644 --- a/gcc/config/darwin.c +++ b/gcc/config/darwin.c @@ -3339,10 +3339,10 @@ darwin_override_options (void) /* Disable -freorder-blocks-and-partition when unwind tables are being emitted for Darwin < 9 (OSX 10.5). - The strategy is, "Unless the User has specifically set/unset an unwind + The strategy is, "Unless the user has specifically set/unset an unwind flag we will switch off -freorder-blocks-and-partition when unwind tables - will be generated". If the User specifically sets flags... we assume - (s)he knows why... */ + will be generated". If the user specifically sets flags, we have to + assume they know why. */ if (generating_for_darwin_version < 9 && OPTION_SET_P (flag_reorder_blocks_and_partition) && flag_reorder_blocks_and_partition -- 2.24.3 (Apple Git-128)