On 12/16/21 21:58, Stefan Kneifel wrote:
Am 15.12.21 um 10:57 schrieb Martin Liška:
On 12/14/21 17:12, Jakub Jelinek wrote:
I'd use INT_TYPE_SIZE - 1 instead of 31. Otherwise LGTM.
Installed with that change, thanks.
Moreover, I'm suggesting a simplification:
The patch removes unneeded loops for cpu_features2 and CONVERT_EXPR
that can be simplified with NOP_EXPR.
Survives i386.exp tests, may I install the patch after testing or
is it a stage1 material?
Thanks,
Martin
The loops indeed seem to be unnecessary.
For safety reasons: what would you think about throwing an ICE if (index >=
SIZE_OF_CPU_FEATURES) ?
This should not happen - however, a lot of things shouldn't happen... and it
might facilitiate locating a potential bug at a later time.
Hello.
Well, I see your point, but I don't think it's necessary as the macro is well
defined.
Note we have a ASAN and UBSAN bootstrap that would caught such an error.
Cheers,
Martin
Regards, Stefan
