> On 10 Dec 2021, at 16:42, Jonathan Wakely <jwakely....@gmail.com> wrote: > > > OK to commit then, thanks. > > The comment is a bit misleading though: > > +// libstdc++ relies on C99 features for virtually all versions of C++, > +// up to at least C++98. > +#undef _C99 > +#define _C99 1 > > The "up to" seems backwards, I'd expect it to say "down to" or "as far > back as at least C++98". > > But there's nothing older than C++98 anyway, so this just means "all > versions", there's no "virtually" about it. > > Please just say "libstdc++ relies on C99 features for all versions of C++". Sure, thanks Jonathan. Yes, I agree the comment is confused. I hesitated between a couple of perspectives and just mixed things up. Thanks for your prompt review! Olivier
Re: [PATCH] Define _C99 in libstdc++ vxworks/os_defines.h
Olivier Hainque via Gcc-patches Fri, 10 Dec 2021 08:16:35 -0800
- [PATCH] Define _C99 in libstdc++ vxworks/... Olivier Hainque via Gcc-patches
- Re: [PATCH] Define _C99 in libstdc++... Rasmus Villemoes via Gcc-patches
- Re: [PATCH] Define _C99 in libst... Jonathan Wakely via Gcc-patches
- Re: [PATCH] Define _C99 in l... Olivier Hainque via Gcc-patches