Re: [PATCH, v5, OpenMP 5.0] Improve OpenMP target support for C++ [PR92120 v5]

[Chung-Lin Tang]

On 2021/12/4 12:47 AM, Jakub Jelinek wrote:

On Tue, Nov 16, 2021 at 08:43:27PM +0800, Chung-Lin Tang wrote:

2021-11-16  Chung-Lin Tang  <clt...@codesourcery.com>

        PR middle-end/92120

gcc/cp/ChangeLog:

...

+         if (allow_zero_length_array_sections)
+           {
+             /* When allowing attachment to zero-length array sections, we
+                allow attaching to NULL pointers when the target region is not
+                mapped.  */
+             data = 0;
+           }

No {}s around single statement if body.

Otherwise LGTM.

        Jakub

Thanks for the review and approval, Jakub.

Thomas, I pushed another 2766448c5cc3efc4 commit to fix the non-offload config 
FAILs, just FYI.

Chung-Lin