On 12/7/2021 7:00 PM, Alexandre Oliva via Gcc-patches wrote:
The testcase shows malformed asms in one block confuse reg-stack logic
in another block. Moving the resetting of any_malformed_asm to the
end of the pass enables it to take effect throughout the affected
function.
Regstrapped on x86_64-linux-gnu. Ok to install?
for gcc/ChangeLog
PR target/103097
* reg-stack.c (convert_regs_1): Move any_malformed_asm
resetting...
(reg_to_stack): ... here.
for gcc/testsuite/ChangeLog
PR target/103097
* gcc.target/i386/pr103097.c: New.
So it's "stickier" after your change. ie, instead of indicating if
there was a malformed insn in a block, it's did we find a malformed insn
anywhere. Which implies the comment before the declaration of
any_malformed_asm needs a trivial update since it stated "malformed
insns in a block".
OK with the trivial comment update.
jeff
