On 9/22/2021 5:03 AM, Thomas Schwinge wrote:
Hi!
On 2021-09-19T11:35:00-0600, Jeff Law via Gcc-patches<gcc-patches@gcc.gnu.org>
wrote:
A couple of goacc tests do not have unique names.
Thanks for fixing this up, and sorry, largely my "fault", I suppose. ;-|
No worries. I suspect there's still a ton of these lying around. It
isn't until one of the duplicate test names starts to fail that it
causes headaches.
This causes problems
for the test comparison script when one of the test passes and the other
fails -- in this scenario the test comparison script claims there is a
regression.
So I understand correctly that this is a problem not just for actual
mixed PASS vs. FAIL (which we'd like you to report anyway!) that appear
for the same line, but also for mixed PASS vs. XFAIL? (Because, the
latter appears to be what you're addressing with your commit here.)\
Correct. The comparison script gets awful confused when it finds two
tests with the same name and different PASS/FAIL states.
This slipped through for a while because I had turned off x86_64 testing
(others test it regularly and I was revamping the tester's hardware
requirements). Now that I've acquired more x86_64 resources and turned
on native x86 testing again, it's been flagged.
(I don't follow that argument -- these test cases should be all generic?
Anyway, not important, I guess.)
I'd have to dig around, but I'd guess none of the other targets have the
appropriate bits enabled to test hte goacc stuff.
0001-Make-sure-that-we-get-unique-test-names-if-several-D.patch
From 6e3ae5784888be70056ccc3bb7d379fa8e7f6fc0 Mon Sep 17 00:00:00 2001
From: Thomas Schwinge<tho...@codesourcery.com>
Date: Wed, 22 Sep 2021 12:42:41 +0200
Subject: [PATCH] Make sure that we get unique test names if several DejaGnu
directives refer to the same line
gcc/testsuite/
* lib/gcc-dg.exp (process-message): Make sure that we get unique
test names.
I like it. Though trying to warp my head around tcl/expect these days
just makes me want to cry. My only worry would be whether or not the
change would confuse people. Though I guess ultimately it'll point to
the absolute line which disambiguates for the scripts and is still
sufficient for humans to quickly see what went wrong.
I'd say let's get it installed and see if there's any fallout. It
obviously just affects the testing harness, so we have more wiggle room
if something goes wrong.
jeff
