On Thu, Dec 2, 2021 at 3:07 PM Martin Liška <mli...@suse.cz> wrote:
>
> On 11/30/21 10:33, Richard Biener wrote:
> > and the "docs" say
> >
> >    /* The switch is enabled when FLAG_VAR is nonzero.  */
> >    CLVC_BOOLEAN,
>
> That's bogus, because real meaning of CLVC_BOOLEAN is that it holds an 
> integer value.
> It can be just true/false for a simple flag, can be 0,1,2 for things like 
> flag_lifetime_dse,
> or it can be an arbitrary integer value for things like params.
>
> That said, I would suggest removing that..
>
> Thoughts about the patch?

+           return v > 0 ? (v < 0 ? -1 : 1) : 0;

the ?:s look odd to me, the above is equivalent to v >  0 ? 1 : 0, no?
Did you mean to make v > 0 v != 0?

> Martin

Reply via email to