On 30/11/2021 19:38, Florian Weimer wrote: > * Alex Coplan via Gcc-patches: > > > Bootstrapped and regtested on aarch64-linux-gnu, x86_64-linux-gnu, and > > arm-linux-gnueabihf: no regressions. > > > > I'd appreciate any feedback. Is it OK for trunk? > > Does this need an ABI warning?
That's a good question. I'm not sure exactly what changes merit an ABI warning in GCC. In this case, we aren't changing how the parameter is passed in the sense that the callee can still locate it in the same way (by following the pointer in the appropriate GPR), we're simply increasing the alignment of the stack slot used for the indirected copy. So on this basis I would guess that it doesn't need a warning, but I'm happy to be corrected. Thanks, Alex > > Thanks, > Florian >
