Hi! While looking at a proposed vendor backport, I've noticed some formatting issues in x86-tune.def. Also, in all spots m_GENERIC comes last, except one recently changed, I think it is useful to have m_GENERIC always last for consistency.
Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk as obvious. 2021-12-01 Jakub Jelinek <ja...@redhat.com> * config/i386/x86-tune.def (X86_TUNE_SCHEDULE, X86_TUNE_SSE_PARTIAL_REG_FP_CONVERTS_DEPENDENCY, X86_TUNE_MISALIGNED_MOVE_STRING_PRO_EPILOGUES): Formatting fixes. (X86_TUNE_USE_GATHER): Put m_GENERIC last for consistency. --- gcc/config/i386/x86-tune.def.jj 2021-11-11 14:35:37.537349474 +0100 +++ gcc/config/i386/x86-tune.def 2021-11-30 15:26:24.126226934 +0100 @@ -42,7 +42,7 @@ see the files COPYING3 and COPYING.RUNTI DEF_TUNE (X86_TUNE_SCHEDULE, "schedule", m_PENT | m_LAKEMONT | m_PPRO | m_CORE_ALL | m_BONNELL | m_SILVERMONT | m_INTEL | m_KNL | m_KNM | m_K6_GEODE | m_AMD_MULTIPLE | m_GOLDMONT - | m_GOLDMONT_PLUS | m_TREMONT | m_ALDERLAKE |m_GENERIC) + | m_GOLDMONT_PLUS | m_TREMONT | m_ALDERLAKE | m_GENERIC) /* X86_TUNE_PARTIAL_REG_DEPENDENCY: Enable more register renaming on modern chips. Preffer stores affecting whole integer register @@ -70,7 +70,7 @@ DEF_TUNE (X86_TUNE_SSE_PARTIAL_REG_DEPEN DEF_TUNE (X86_TUNE_SSE_PARTIAL_REG_FP_CONVERTS_DEPENDENCY, "sse_partial_reg_fp_converts_dependency", m_PPRO | m_P4_NOCONA | m_CORE_ALL | m_BONNELL | m_AMDFAM10 - | m_BDVER | m_ZNVER | m_ALDERLAKE| m_GENERIC) + | m_BDVER | m_ZNVER | m_ALDERLAKE | m_GENERIC) /* X86_TUNE_SSE_PARTIAL_REG_CONVERTS_DEPENDENCY: This knob avoids partial write to the destination in scalar SSE conversion from integer to FP. */ @@ -298,7 +298,7 @@ DEF_TUNE (X86_TUNE_PREFER_KNOWN_REP_MOVS DEF_TUNE (X86_TUNE_MISALIGNED_MOVE_STRING_PRO_EPILOGUES, "misaligned_move_string_pro_epilogues", m_386 | m_486 | m_CORE_ALL | m_AMD_MULTIPLE | m_TREMONT - | m_ALDERLAKE |m_GENERIC) + | m_ALDERLAKE | m_GENERIC) /* X86_TUNE_USE_SAHF: Controls use of SAHF. */ DEF_TUNE (X86_TUNE_USE_SAHF, "use_sahf", @@ -460,7 +460,7 @@ DEF_TUNE (X86_TUNE_AVOID_4BYTE_PREFIXES, /* X86_TUNE_USE_GATHER: Use gather instructions. */ DEF_TUNE (X86_TUNE_USE_GATHER, "use_gather", - ~(m_ZNVER1 | m_ZNVER2 | m_GENERIC | m_ALDERLAKE)) + ~(m_ZNVER1 | m_ZNVER2 | m_ALDERLAKE | m_GENERIC)) /* X86_TUNE_AVOID_128FMA_CHAINS: Avoid creating loops with tight 128bit or smaller FMA chain. */ Jakub