On Oct 18, 2021, Richard Biener via Gcc-patches <gcc-patches@gcc.gnu.org> wrote:
> On Mon, Oct 18, 2021 at 10:54 AM Martin Liška <mli...@suse.cz> wrote: >> >> The macros correspond 1:1 to an option flags and make it harder >> to find all usages of the flags. >> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. >> >> Ready to be installed? > Hmm, they were introduced on purpose Yup. Though there is a 1:1 equivalence right now, conceptually other kinds of debug marker stmts, and of debug bind stmts, could be introduced, and then the macros would be adjusted to encompass the new functionality, covering presumably different options as well. By removing the macros, every use of the options would have to be reassessed to tell whether it needs to be changed to cover the new features, or left alone because it's really meant to refer to that specific option. So I find the abstraction useful. However, I don't have plans to add other kinds of debug stmts, and I don't know of anyone else who does, so I won't stand in the way if others think removing these abstractions is a positive change. -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Disinformation flourishes because many people care deeply about injustice but very few check the facts. Ask me about <https://stallmansupport.org>
