On Fri, Nov 12, 2021 at 03:34:17PM +0100, Martin Liška wrote:
> On 11/11/21 18:52, Segher Boessenkool wrote:
> >You forgot to send the commit message though?
>
> No, the patch is simple so I didn't write any message (except commit title).
How is a maintainer supposed to know what the patch is about, then? Not
all of us are clairvoyant.
> >>--- a/gcc/config/rs6000/rs6000.c
> >>+++ b/gcc/config/rs6000/rs6000.c
> >>@@ -3472,13 +3472,8 @@ rs6000_override_options_after_change (void)
> >> /* Explicit -funroll-loops turns -munroll-only-small-loops off, and
> >> turns -frename-registers on. */
> >> if ((OPTION_SET_P (flag_unroll_loops) && flag_unroll_loops)
> >>- || (OPTION_SET_P (flag_unroll_all_loops)
> >>- && flag_unroll_all_loops))
> >>+ || (OPTION_SET_P (flag_unroll_all_loops) &&
> >>flag_unroll_all_loops))
> >> {
> >>- if (!OPTION_SET_P (unroll_only_small_loops))
> >>- unroll_only_small_loops = 0;
> >>- if (!OPTION_SET_P (flag_rename_registers))
> >>- flag_rename_registers = 1;
> >> if (!OPTION_SET_P (flag_cunroll_grow_size))
> >> flag_cunroll_grow_size = 1;
> >> }
> >
> >So some explanation for these two changes would be good to have.
>
> It's explained in the ChangeLog entry.
It is not. Besides, a changelog should describe *what* changed, not
*why*, anyway.
> >>diff --git a/gcc/config/rs6000/rs6000.opt b/gcc/config/rs6000/rs6000.opt
> >>index 9d7878f144a..faeb7423ca7 100644
> >>--- a/gcc/config/rs6000/rs6000.opt
> >>+++ b/gcc/config/rs6000/rs6000.opt
> >>@@ -546,7 +546,7 @@ Target Undocumented Var(rs6000_optimize_swaps) Init(1)
> >>Save
> >> Analyze and remove doubleword swaps from VSX computations.
> >>
> >> munroll-only-small-loops
> >>-Target Undocumented Var(unroll_only_small_loops) Init(0) Save
> >>+Target Undocumented Var(unroll_only_small_loops) Init(0) Save
> >>EnabledBy(funroll-loops)
> >
> >You used format=flowed it seems? Don't. Patches are mangled with it :-(
>
> No, it's correct:
> https://gcc.gnu.org/pipermail/gcc-patches/2021-November/583310.html
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
It is not correct. Please fix.
Segher
