on 2021/11/10 下午6:03, Segher Boessenkool wrote:
> Hi!
>
> On Wed, Nov 10, 2021 at 05:39:27PM +0800, Kewen.Lin wrote:
>> @@ -27779,10 +27779,10 @@ Enable/disable the @var{__float128} keyword for
>> IEEE 128-bit floating point
>> and use either software emulation for IEEE 128-bit floating point or
>> hardware instructions.
>>
>> -The VSX instruction set (@option{-mvsx}, @option{-mcpu=power7},
>> -@option{-mcpu=power8}), or @option{-mcpu=power9} must be enabled to
>> -use the IEEE 128-bit floating point support. The IEEE 128-bit
>> -floating point support only works on PowerPC Linux systems.
>> +The VSX instruction set (@option{-mvsx}, @option{-mcpu=power7} (or later
>> +@var{cpu_type})) must be enabled to use the IEEE 128-bit floating point
>> +support. The IEEE 128-bit floating point support only works on PowerPC
>> +Linux systems.
>
> I'd just say -mvsx. This is default on for -mcpu=power7 and later, and
> cannot be enabled elsewhere, but that is beside the point.
>
> If you say more than the essentials here it becomes harder to read
> (simply because there is more to read then), harder to find what you
> are looking for, and harder to keep it updated if things change (like
> what this patch is for :-) )
>
> The part about "works only on Linux" isn't quite true. "Is only
> supported on Linux" is a bit better.
>
>> Generate (do not generate) addressing modes using prefixed load and
>> -store instructions when the option @option{-mcpu=future} is used.
>> +store instructions. The @option{-mprefixed} option requires that
>> +the option @option{-mcpu=power10} (or later @var{cpu_type}) is enabled.
>
> Just "or later" please. The "CPU_TYPE" thing is local to the -mcpu=
> description, let's not refer to it from elsewhere.
>
>> @item -mmma
>> @itemx -mno-mma
>> @opindex mmma
>> @opindex mno-mma
>> -Generate (do not generate) the MMA instructions when the option
>> -@option{-mcpu=future} is used.
>> +Generate (do not generate) the MMA instructions. The @option{-mma}
>> +option requires that the option @option{-mcpu=power10} (or later
>> +@var{cpu_type}) is enabled.
>
> (once more)
>
> Okay for trunk with those changes. Thanks!
>
>
Thanks! All comments are addressed and committed as r12-5143.
BR,
Kewen
> Segher
>
