On Tue, Oct 5, 2021 at 5:50 PM Eric Botcazou via Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > > Hi, > > the first issue is that the !gotoff_operand path of legitimize_pic_address in > large PIC model does not make use of REG when it is available, which breaks > for thunks because new pseudo-registers can no longer be created. And the > second issue is that the system compiler (LLVM) generates @GOTOFF in large > model even for RTP, so we do the same. > > Tested on x86-64/Linux and VxWorks, OK for the mainline? > > > 2021-10-05 Eric Botcazou <ebotca...@adacore.com> > > * config/i386/i386.c (legitimize_pic_address): Adjust comment and > use the REG argument on the CM_LARGE_PIC code path as well. > * config/i386/predicates.md (gotoff_operand): Do not treat VxWorks > specially with the large code models.
LGTM for the generic part, no idea for VxWorks. Thanks, Uros.
