Hi!

On Wed, Sep 01, 2021 at 11:13:49AM -0500, Bill Schmidt wrote:
>       * config/rs6000/rs6000.c (rs6000_builtin_reciprocal): Use
>       rs6000_builtin_decls_x when appropriate.
>       (add_condition_to_bb): Likewise.
>       (rs6000_atomic_assign_expand_fenv): Likewise.

> +  tree predicate_decl
> +    = (new_builtins_are_live
> +       ? rs6000_builtin_decls_x[(int) RS6000_BIF_CPU_SUPPORTS]
> +       : rs6000_builtin_decls [(int) RS6000_BUILTIN_CPU_SUPPORTS]);

Please don't randomly parenthesise stuff.  If something in emacs
complains about it, fix *that*?  Or complain back, etc. :-)

> -  tree mffs = rs6000_builtin_decls[RS6000_BUILTIN_MFFS];
> -  tree mtfsf = rs6000_builtin_decls[RS6000_BUILTIN_MTFSF];
> +  tree mffs
> +    = (new_builtins_are_live
> +       ? rs6000_builtin_decls_x[RS6000_BIF_MFFS]
> +       : rs6000_builtin_decls[RS6000_BUILTIN_MFFS]);
> +  tree mtfsf
> +    = (new_builtins_are_live
> +       ? rs6000_builtin_decls_x[RS6000_BIF_MTFSF]
> +       : rs6000_builtin_decls[RS6000_BUILTIN_MTFSF]);
>    tree call_mffs = build_call_expr (mffs, 0);

Same here.

Okay for trunk with that fixed.  Thanks!


Segher

Reply via email to