On Wed, Oct 13, 2021 at 6:42 AM H.J. Lu <hjl.to...@gmail.com> wrote: > > On Wed, Oct 13, 2021 at 6:03 AM Richard Biener > <richard.guent...@gmail.com> wrote: > > > > On Wed, Oct 13, 2021 at 2:56 PM H.J. Lu <hjl.to...@gmail.com> wrote: > > > > > > On Wed, Oct 13, 2021 at 5:45 AM Richard Biener > > > <richard.guent...@gmail.com> wrote: > > > > > > > > On Thu, Sep 2, 2021 at 5:50 PM H.J. Lu <hjl.to...@gmail.com> wrote: > > > > > > > > > > Change in the v2 patch: > > > > > > > > > > 1. Disable static trampolines by default. > > > > > > > > > > > > > > > GCC maintained a copy of libffi snapshot from 2009 and cherry-picked > > > > > fixes > > > > > from upstream over the last 10+ years. In the meantime, libffi > > > > > upstream > > > > > has been changed significantly with new features, bug fixes and new > > > > > target > > > > > support. Here is a set of patches to sync with libffi 3.4.2 release > > > > > and > > > > > make it easier to sync with libffi upstream: > > > > > > > > > > 1. Document how to sync with upstream. > > > > > 2. Add scripts to help sync with upstream. > > > > > 3. Sync with libffi 3.4.2. This patch is quite big. It is availale at > > > > > > > > > > https://gitlab.com/x86-gcc/gcc/-/commit/15e80c879c571f79a0e57702848a9df5fba5be2f > > > > > 4. Integrate libffi build and testsuite with GCC. > > > > > > > > How did you test this? It looks like libgo is the only consumer of > > > > libffi these days. > > > > In particular go/libgo seems to be supported on almost all targets > > > > besides > > > > darwin/windows - did you test cross and canadian configurations? > > > > > > I only tested it on Linux/i686 and Linux/x86-64. My understanding is > > > that > > > the upstream libffi works on Darwin and Windows. > > > > > > > I applaud the attempt to sync to upsteam but I fear you won't get any > > > > "review" > > > > of this massive diff. > > > > > > I believe that it should just work. Our libffi is very much out of date. > > > > Yes, you can hope. And yes, our libffi is out of date. > > > > Can you please do the extra step to test one weird architecture, namely > > powerpc64-aix which is available on the compile-farm? > > I will give it a try and report back. > > > If that goes well I think it's good to "hope" at this point (and plenty of > > time to fix fallout until the GCC 12 release). > > > > Thus OK after the extra testing dance and waiting until early next > > week so others can throw in a veto.
I tried to bootstrap GCC master branch on gcc119.fsffrance.org: * MT/MODEL: 8284-22A * * Partition: gcc119 * * System: power8-aix.osuosl.org * * O/S: AIX V7.2 7200-04-03-2038 I configured GCC with --with-as=/usr/bin/as --with-ld=/usr/bin/ld --enable-version-specific-runtime-libs --disable-nls --enable-decimal-float=dpd --disable-libstdcxx-pch --disable-werror --enable-__cxa_atexit --with-gmp=/opt/cfarm --with-mpfr=/opt/cfarm --with-mpc=/opt/cfarm --with-isl=/opt/cfarm --prefix=/opt/freeware --with-local-prefix=/opt/freeware --enable-languages=c,c++,go I got g++ -g -DIN_GCC -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wno-format -Wmissing-format-at tribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno- overlength-strings -fno-common -DHAVE_CONFIG_H -DGENERATOR_FILE -static-libstd c++ -static-libgcc -Wl,-bbigtoc -Wl,-bmaxdata:0x40000000 -o build/genenums \ build/genenums.o build/read-md.o build/errors.o ../build-powerpc-ibm-aix7.2. 4.0/libiberty/libiberty.a ld: 0711-317 ERROR: Undefined symbol: lexer_line ld: 0711-317 ERROR: Undefined symbol: .yylex(char const**) ld: 0711-317 ERROR: Undefined symbol: .yybegin(char const*) ld: 0711-317 ERROR: Undefined symbol: lexer_toplevel_done ld: 0711-317 ERROR: Undefined symbol: .yyend() ld: 0711-345 Use the -bloadmap or -bnoquiet option to obtain more information. collect2: error: ld returned 8 exit status Makefile:3000: recipe for target 'build/gengtype' failed gmake[5]: *** [build/gengtype] Error 1 David, is there an instruction to bootstrap GCC on AIX? Thanks. -- H.J.