On Wed, Oct 13, 2021 at 1:59 PM Martin Liška <mli...@suse.cz> wrote: > > On 10/13/21 10:47, Richard Biener wrote: > > Let's split this;) The debug_inline_points part is OK. > > Fine. > > > > > How can debug_variable_location_views be ever -1? But the > > debug_variable_location_views part looks OK as well. > > It comes from here: > gvariable-location-views=incompat5 > Common Driver RejectNegative Var(debug_variable_location_views, -1) Init(2) > > but it's fine as using -gvariable-location-views=incompat5 leads to > OPTION_SET_P(debug_variable_location_views) == true. > > > > > More or less all parts that have the variable assigned in a single > > place in gcc/ are OK (dwarf2out_as_locview_support). But the > > main flag_var_tracking* cases need more thorough view, > > maybe we can convert them to single-set code first? > > I don't think so, your have code like > > if (flag_var_tracking_assignments_toggle) > flag_var_tracking_assignments = !flag_var_tracking_assignments; > > which makes it more complicated. Or do I miss something?
It does, yes. But that's a ^ with flag_var_tracking_assignments_toggle ;) It's also one of the more weird flags, so it could be applied after the otherwise single set of flag_var_tracking_assignments ... Richard. > > Cheers, > Martin
