On 10/4/21 23:02, Andrew Pinski wrote:
It might be useful to skip tabs for the same reason as spaces really.
Sure, be my guest.
Martin
From b66d7be2c1b3ac286257e3df4d9796e391751bef Mon Sep 17 00:00:00 2001
From: Martin Liska <mli...@suse.cz>
Date: Mon, 4 Oct 2021 14:06:14 +0200
Subject: [PATCH] target: support spaces in target attribute.
PR target/102374
gcc/ChangeLog:
* config/i386/i386-options.c (ix86_valid_target_attribute_inner_p): Strip whitespaces.
* system.h (strip_whilespaces): New function.
gcc/testsuite/ChangeLog:
* gcc.target/i386/pr102374.c: New test.
---
gcc/config/i386/i386-options.c | 2 ++
gcc/system.h | 21 +++++++++++++++++++++
gcc/testsuite/gcc.target/i386/pr102374.c | 3 +++
3 files changed, 26 insertions(+)
create mode 100644 gcc/testsuite/gcc.target/i386/pr102374.c
diff --git a/gcc/config/i386/i386-options.c b/gcc/config/i386/i386-options.c
index e7a3bd4aaea..c9523b26f49 100644
--- a/gcc/config/i386/i386-options.c
+++ b/gcc/config/i386/i386-options.c
@@ -1146,6 +1146,8 @@ ix86_valid_target_attribute_inner_p (tree fndecl, tree args, char *p_strings[],
next_optstr = NULL;
}
+ p = strip_whitespaces (p, &len);
+
/* Recognize no-xxx. */
if (len > 3 && p[0] == 'n' && p[1] == 'o' && p[2] == '-')
{
diff --git a/gcc/system.h b/gcc/system.h
index adde3e264b6..17a6a553b0b 100644
--- a/gcc/system.h
+++ b/gcc/system.h
@@ -1305,4 +1305,25 @@ startswith (const char *str, const char *prefix)
return strncmp (str, prefix, strlen (prefix)) == 0;
}
+/* Strip white spaces from STRING with LEN length.
+ A stripped string is returned and LEN is updated accordingly. */
+
+static inline char *
+strip_whitespaces (char *string, size_t *len)
+{
+ while (string[0] == ' ' || string[0] == '\t')
+ {
+ --(*len);
+ ++string;
+ }
+
+ while (string[*len - 1] == ' ' || string[*len - 1] == '\t')
+ {
+ string[*len - 1] = '\0';
+ --(*len);
+ }
+
+ return string;
+}
+
#endif /* ! GCC_SYSTEM_H */
diff --git a/gcc/testsuite/gcc.target/i386/pr102374.c b/gcc/testsuite/gcc.target/i386/pr102374.c
new file mode 100644
index 00000000000..21aa76011ed
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr102374.c
@@ -0,0 +1,3 @@
+/* PR target/102374 */
+
+void calculate_sse(void) __attribute__ ((__target__ (" no-avx, sse2 ")));
--
2.33.0
