On 9/21/21 19:07, Barrett Adair wrote:
Thanks for the feedback. I addressed the concerns raised in the previous
patch.
I ran tests with this, after rebasing:
../gcc/configure --prefix=$MYPREFIX --enable-languages=c++
--enable-bootstrap --enable-checking=yes,extra --disable-multilib &&
make -j6 && make check
I have the "expected" failures:
* guality
* xtreme-header-4_b.C
* 20050826-2.c scan-tree-dump-not dom2 "Invalid sum"
Additionally, libstdc++-v3/testsuite/30_threads/jthread/95989.cc results
in a target segfault, but this also happens when manually building with
Ubuntu's g++-11 and the specified flags. It looks like this test
predates the 11.1 release, so I doubt this crash is related to the patch.
Other than that, no FAIL or XPASS.
Subject: [PATCH] Fix template instantiation comparison in redeclarations
---
gcc/cp/pt.c | 20 +++++++++++++++++++
Thanks. Your patch still needs a description (maybe condensed from the
intro to the first version of the patch) and ChangeLog entries. If you
run contrib/gcc-git-customization.sh it will define an alias that you
can use to add skeleton ChangeLog entries to the commit with
git gcc-commit-mklog --amend
Sorry I didn't catch this before.
Jason
